Add command for setting SOC to the car simulator #1670
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzbr
requested review from
Pietfried,
SebaLukas,
james-ctc and
mlitre
as code owners
nzbr
force-pushed
the
feat/sim-set-soc
branch
from
6a17c68 to
57cfefa
Compare
Signed-off-by: Wire Jansen <mail@nzbr.de>
nzbr
force-pushed
the
feat/sim-set-soc
branch
from
57cfefa to
c4bde8f
Compare
Contributor
|
@hikinggrass this looks good to me, but I wouldn't mind a second review here :) |
hikinggrass
approved these changes
Jan 7, 2026
mlitre
approved these changes
Jan 7, 2026
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Extends the car simulator with a command that may be used to set the SOC to a custom value before plugging it in.
The command can be used with
set_soc <soc>, where thesocargument is parsed as a floating point number that must be in the interval [0,100].Issue ticket number and link
Checklist before requesting a review